picocrypt-ng: Add version 2.12 by scillidan · Pull Request #17903 · ScoopInstaller/Extras

scillidan · 2026-05-27T08:47:05Z

Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
I have read the Contributing Guide

coderabbitai · 2026-05-27T08:47:20Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR adds a new Scoop Extras package manifest for Picocrypt-NG v2.12. The manifest includes version, description, homepage, GPL-3.0-or-later license, two 64-bit artifacts (portable and CLI) with targets and SHA-256 hashes, a "Picocrypt NG" shortcut, and autoupdate entries using GitHub release download URLs plus GitHub tag API-based hash discovery.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description is incomplete; it references a closed issue but lacks details about the changes and version information.	Expand the description to clarify which version was added and summarize the manifest configuration changes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The linked issue `#17170` requests adding Picocrypt-NG as a package; the PR adds the manifest with proper metadata, URLs, and autoupdate configuration meeting stated criteria.
Out of Scope Changes check	✅ Passed	The PR introduces only the picocrypt-ng.json manifest file, which is directly in scope for the package addition request in issue `#17170`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately reflects the main change: adding Picocrypt-NG package metadata for version 2.12 to the repository.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

bucket/picocrypt-ng.json (1)

1-26: Run local manifest validation before merge.

Please verify with:

scoop config debug true
scoop config gh_token <your-github-token>   # read-only token
.\bin\checkver.ps1 -App picocrypt-ng -f
.\bin\formatjson.ps1 -App picocrypt-ng
scoop install bucket\picocrypt-ng.json -a 64bit

If any checklist ambiguity comes up, use:

As per coding guidelines: “Provide clear instructions for testing the manifest locally before submission” and include contribution/wiki links for guidance.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/picocrypt-ng.json` around lines 1 - 26, Add clear local validation and
testing steps for the picocrypt-ng manifest (picocrypt-ng.json) to your PR
description or a CONTRIBUTING note: list the exact commands to run (enable
debug, set GH token, run .\bin\checkver.ps1 -App picocrypt-ng -f,
.\bin\formatjson.ps1 -App picocrypt-ng, and scoop install
bucket\picocrypt-ng.json -a 64bit), and include links to the Scoop contribution
and manifest wiki pages for guidance (ScoopInstaller/.github CONTRIBUTING.md and
Scoop Wiki App-Manifests). This ensures reviewers can reproduce manifest
validation before merge; update the PR text (not the JSON fields) to contain
those commands and links.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/picocrypt-ng.json`:
- Around line 1-26: Add clear local validation and testing steps for the
picocrypt-ng manifest (picocrypt-ng.json) to your PR description or a
CONTRIBUTING note: list the exact commands to run (enable debug, set GH token,
run .\bin\checkver.ps1 -App picocrypt-ng -f, .\bin\formatjson.ps1 -App
picocrypt-ng, and scoop install bucket\picocrypt-ng.json -a 64bit), and include
links to the Scoop contribution and manifest wiki pages for guidance
(ScoopInstaller/.github CONTRIBUTING.md and Scoop Wiki App-Manifests). This
ensures reviewers can reproduce manifest validation before merge; update the PR
text (not the JSON fields) to contain those commands and links.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5fb45b8f-80dc-4756-b85d-457046413412

📥 Commits

Reviewing files that changed from the base of the PR and between ec31d16 and 7487bf6.

📒 Files selected for processing (1)

bucket/picocrypt-ng.json

scillidan · 2026-05-27T08:50:28Z

/verify

github-actions · 2026-05-27T08:51:45Z

All changes look good.

Wait for review from human collaborators.

picocrypt-ng

Check the full log for details.

aliesbelik · 2026-06-10T21:21:10Z

/verify

github-actions · 2026-06-10T21:22:51Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

picocrypt-ng

Check the full log for details.

aliesbelik

Guess manifest could provide cli version along with main app.
Please update to the latest version.

Co-authored-by: Aliaksandr Belik <1752374+aliesbelik@users.noreply.github.com>

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/picocrypt-ng.json`:
- Line 36: The JSON contains invalid escape sequences `\(` and `\)` inside the
"find" regex string; update the string literal used in the "find" field (the
value starting with "sha256(Picocrypt-NG-portable.exe)...") to double-escape the
backslashes before the parentheses so they become `\\(` and `\\)`, e.g. change
"sha256\(Picocrypt-NG-portable.exe\)\\s+$sha256" to
"sha256\\(Picocrypt-NG-portable.exe\\)\\s+$sha256" and make the same change for
the other occurrence referenced in the comment.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 385bae56-6bda-4e65-a7ff-924a6d849fac

📥 Commits

Reviewing files that changed from the base of the PR and between f6abbe8 and 7e78e5b.

📒 Files selected for processing (1)

bucket/picocrypt-ng.json

coderabbitai

♻️ Duplicate comments (1)

bucket/picocrypt-ng.json (1)

36-36: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Fix invalid JSON escaping in autoupdate hash regex.

Line 36 and Line 40 use \( / \), which are invalid JSON escapes and make the manifest unparsable. Use \\( and \\) in JSON string literals.

Also, please refer to the Scoop contribution docs for manifest formatting expectations:

Suggested patch

-                        "regex": "sha256\(Picocrypt-NG-portable.exe\)\\s+$sha256"
+                        "regex": "sha256\\(Picocrypt-NG-portable.exe\\)\\s+$sha256"
...
-                        "regex": "sha256\(Picocrypt-NG-cli.exe\)\\s+$sha256"
+                        "regex": "sha256\\(Picocrypt-NG-cli.exe\\)\\s+$sha256"

#!/bin/bash
set -euo pipefail

# 1) Verify JSON parses
jq empty bucket/picocrypt-ng.json

# 2) Show current regex lines for manual confirmation
rg -n '"regex":' bucket/picocrypt-ng.json

Also applies to: 40-40

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/picocrypt-ng.json` at line 36, The "regex" string literals in
picocrypt-ng.json currently contain single backslash escapes `\(` and `\)` which
are invalid in JSON; update both regex values (the "regex" entries referencing
sha256(Picocrypt-NG-portable.exe) and the other occurrence) to use double
backslashes `\\(` and `\\)` so the JSON string contains literal parentheses in
the regex, then validate the manifest parses (e.g., with jq) and re-run any
manifest linting.

Source: Linters/SAST tools

🧹 Nitpick comments (1)

bucket/picocrypt-ng.json (1)

1-46: Run local Scoop manifest validation steps before merge.

Recommended checks for this manifest (picocrypt-ng):

scoop config debug true
scoop config gh_token <your-github-token>  # read-only token
.\bin\checkver.ps1 -App picocrypt-ng -f
.\bin\formatjson.ps1 -App picocrypt-ng
scoop install bucket/picocrypt-ng.json -a 64bit

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/picocrypt-ng.json` around lines 1 - 46, Run the local Scoop manifest
validation and installation checks for the manifest "picocrypt-ng"
(bucket/picocrypt-ng.json): enable debug and set a GitHub read-only token, then
execute the checkver and formatjson scripts for the App name "picocrypt-ng" and
attempt a 64-bit install to catch autoupdate/checkver or JSON formatting issues;
if any step fails, fix the manifest fields referenced in the diff (e.g.,
"checkver", "autoupdate", "architecture.64bit.url", "architecture.64bit.hash",
"bin", "shortcuts") so checkver regexes and hashes are correct and formatjson
passes, then re-run the validation until all steps succeed before merging.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@bucket/picocrypt-ng.json`:
- Line 36: The "regex" string literals in picocrypt-ng.json currently contain
single backslash escapes `\(` and `\)` which are invalid in JSON; update both
regex values (the "regex" entries referencing sha256(Picocrypt-NG-portable.exe)
and the other occurrence) to use double backslashes `\\(` and `\\)` so the JSON
string contains literal parentheses in the regex, then validate the manifest
parses (e.g., with jq) and re-run any manifest linting.

---

Nitpick comments:
In `@bucket/picocrypt-ng.json`:
- Around line 1-46: Run the local Scoop manifest validation and installation
checks for the manifest "picocrypt-ng" (bucket/picocrypt-ng.json): enable debug
and set a GitHub read-only token, then execute the checkver and formatjson
scripts for the App name "picocrypt-ng" and attempt a 64-bit install to catch
autoupdate/checkver or JSON formatting issues; if any step fails, fix the
manifest fields referenced in the diff (e.g., "checkver", "autoupdate",
"architecture.64bit.url", "architecture.64bit.hash", "bin", "shortcuts") so
checkver regexes and hashes are correct and formatjson passes, then re-run the
validation until all steps succeed before merging.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4bb02d78-3c61-44e4-8976-e0759ca7eec1

📥 Commits

Reviewing files that changed from the base of the PR and between 7e78e5b and 4245f71.

📒 Files selected for processing (1)

bucket/picocrypt-ng.json

scillidan · 2026-06-11T04:03:15Z

/verify

github-actions · 2026-06-11T04:04:25Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

picocrypt-ng

Check the full log for details.

scillidan · 2026-06-11T06:14:48Z

/verify

github-actions · 2026-06-11T06:16:32Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

picocrypt-ng

Check the full log for details.

scillidan · 2026-06-11T07:07:52Z

/verify

github-actions · 2026-06-11T07:09:07Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

picocrypt-ng

Check the full log for details.

aliesbelik · 2026-06-11T19:45:02Z

/verify

github-actions · 2026-06-11T19:46:58Z

All changes look good.

Wait for review from human collaborators.

picocrypt-ng

Check the full log for details.

scillidan · 2026-06-12T00:46:20Z

Thanks for your review!

picocrypt-ng: Add version 2.09

7487bf6

coderabbitai Bot reviewed May 27, 2026

View reviewed changes

github-actions Bot added the review-needed label May 27, 2026

arvdk added a commit to arvdk/Extras that referenced this pull request Jun 9, 2026

Merge PR ScoopInstaller#17903

15832b3

github-actions Bot added manifest-fix-needed and removed review-needed labels Jun 10, 2026

aliesbelik requested changes Jun 10, 2026

View reviewed changes

Comment thread bucket/picocrypt-ng.json Outdated

Comment thread bucket/picocrypt-ng.json

Comment thread bucket/picocrypt-ng.json Outdated

scillidan and others added 3 commits June 11, 2026 03:24

picocrypt-ng: provide cli version along with main app

7edf613

Co-authored-by: Aliaksandr Belik <1752374+aliesbelik@users.noreply.github.com>

picocrypt-ng: add bin field

f6abbe8

Co-authored-by: Aliaksandr Belik <1752374+aliesbelik@users.noreply.github.com>

picocrypt-ng: Update version to 2.12; add hash in autoupdate

7e78e5b

coderabbitai Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread bucket/picocrypt-ng.json Outdated

picocrypt-ng: fix hash in autoupdate

4245f71

coderabbitai Bot reviewed Jun 11, 2026

View reviewed changes

scillidan added 3 commits June 11, 2026 03:50

picocrypt-ng: fix hash in autoupdate

44d7ddc

picocrypt-ng: chore

334832a

picocrypt-ng: chore

9a69bb2

picocrypt-ng: fix hash in autoupdate

5d28813

scillidan added 3 commits June 11, 2026 06:55

picocrypt-ng: fix hash in autoupdate

3bccd66

picocrypt-ng: fix hash in autoupdate

a5712b8

picocrypt-ng: chore

7f6b673

picocrypt-ng@2.12: Fix hash autoupdate

7ef2677

github-actions Bot added review-needed and removed manifest-fix-needed labels Jun 11, 2026

aliesbelik changed the title ~~picocrypt-ng: Add version 2.09~~ picocrypt-ng: Add version 2.12 Jun 11, 2026

aliesbelik merged commit 318c591 into ScoopInstaller:master Jun 11, 2026
3 checks passed

scillidan deleted the picocrypt-ng branch June 12, 2026 00:46

Conversation

scillidan commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Estimated code review effort

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

scillidan commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

picocrypt-ng

Uh oh!

aliesbelik commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

picocrypt-ng

Uh oh!

aliesbelik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

scillidan commented Jun 11, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026

picocrypt-ng

Uh oh!

scillidan commented Jun 11, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026

picocrypt-ng

Uh oh!

scillidan commented Jun 11, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026

picocrypt-ng

Uh oh!

aliesbelik commented Jun 11, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026

picocrypt-ng

Uh oh!

Uh oh!

scillidan commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented May 27, 2026 •

edited

Loading